Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sendReportTo Doc Apply to All report* functions, Add Beacon Info… #967

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Dec 26, 2023

  1. Make sendReportTo Doc Apply to All report* functions, Add Beacon Info…

    …, Slight Flow Change
    
    Original intention here was to add what I think is a clarification about how the reporting functions send the signal back to the ad tech's servers. As I was digging through I figured a beacon would be used and I thiiink that is supported by slightly-above-cursory-inspection [here](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/interest_group/interest_group_auction_reporter.cc;l=264?q=reportResult&ss=chromium%2Fchromium%2Fsrc:content%2Fbrowser%2Finterest_group%2F).
    
    As I went to write the update I thought it made sense to add it to the paragraph I modified, but wanted it to apply across both reportResult and reportWin, and since that paragraph I think should apply to both as well, I think it makes sense to push it up the "stack" a level. Then, given the move, I changed a few things for flow.
    
    Last thing: as I was writing this PR commit, I realized this might be on the side "not a generic spec piece for any browser implementing Fledge, but still relevant for most readers of this doc"...since I don't think we talked more about that yet, I'm just gonna propose this and we can talk about what makes sense.
    thegreatfatzby committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    afdbec8 View commit details
    Browse the repository at this point in the history