Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NotAllowedError instead of SecurityError #267

Merged

Conversation

mjwilson-google
Copy link
Contributor

This is to fix #261

@mjwilson-google mjwilson-google self-assigned this Sep 4, 2024
@mjwilson-google mjwilson-google removed their assignment Sep 4, 2024
@mjwilson-google
Copy link
Contributor Author

Paul, please take a look since this will affect the implementations.

@mjwilson-google mjwilson-google merged commit 3c36dcb into WebAudio:gh-pages Sep 5, 2024
1 check passed
@mjwilson-google mjwilson-google deleted the not-allowed-error branch September 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rejecting the MIDI permission should use NotAllowedError, not SecurityError
2 participants