Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: single-sig IPEX apply, offer, agree" #268

Conversation

iFergal
Copy link
Contributor

@iFergal iFergal commented Jul 16, 2024

Reverts #234

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (cf1fc64) to head (7c4ab6c).
Report is 1 commits behind head on main.

Files Patch % Lines
src/keri/app/aiding.ts 33.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   83.74%   83.74%           
=======================================
  Files          47       47           
  Lines        4215     4215           
  Branches     1048     1022   -26     
=======================================
  Hits         3530     3530           
- Misses        657      681   +24     
+ Partials       28        4   -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan
Copy link
Collaborator

lenkan commented Jul 16, 2024

@iFergal I think the failing build is due to the update from keria:0.1.2 to keria:0.1.3. For some reason I had to change to wget and use the docker network hostname to do the healthcheck. I believe it is safe to merge this and then just open a PR with the new healthcheck.

Or if we add this to the commit: https://github.com/cardano-foundation/signify-ts/pull/2/files

It looks like the :latest keria image is the dev tag. So that is probably why it is failing.

@lenkan lenkan merged commit e7aaf3c into WebOfTrust:main Jul 16, 2024
6 of 8 checks passed
@iFergal iFergal deleted the revert-234-feat/singleSigIpexApplyOfferAgree branch July 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants