Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special page to import an entity #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lucaswerkmeister
Copy link
Member

Special:ImportEntity imports a single entity and then redirects to the imported entity.

Two new configuration options are added to provide a human-readable link to the remote Wikibase installation on the special page, in addition to the API URL that the extension needs to actually import the entity.

Importing statements does not work properly, since the page_props table is apparently not updated at all anymore once the first attempt to import statements is made. For now, the checkbox to import statements is disabled, and statements are never imported.

This commit is not yet ready for merging, since it currently includes two changes to EntityImporterFactory; the change from private to public might be necessary, but the commented-out toplevel statements probably have some better solution.

Special:ImportEntity imports a single entity and then redirects to the
imported entity.

Two new configuration options are added to provide a human-readable link
to the remote Wikibase installation on the special page, in addition to
the API URL that the extension needs to actually import the entity.

Importing statements does not work properly, since the page_props table
is apparently not updated at all anymore once the first attempt to
import statements is made. For now, the checkbox to import statements is
disabled, and statements are never imported.

This commit is not yet ready for merging, since it currently includes
two changes to EntityImporterFactory; the change from private to public
might be necessary, but the commented-out toplevel statements probably
have some better solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant