Fix race condition with multiple requests (android)

[moperacz]

Explanation of this issue
#873

not sure what exactly the lines 714-716 are doing... so i deleted them 😀 (works for me)

[aogilvie]

@moperacz Hi thanks for the PR. Can you provide test code? Thanks.

[moperacz]

test as in java tests? or javascript "proof" that this works 😉

the javascript is the same as in #873

(copied from @ggmichaelgo issue)

facebookConnectPlugin.api('/me', null, function(response){
  console.log('me');
  console.log(response);
});
setTimeout(function(){
  facebookConnectPlugin.api('/me/permissions', null, function(response){
    console.log('permission');
    console.log(response);
  });
}, 70)

In the console, only the "/me/permissions" request will get returned with the "/me" request's response data.
This is happening because on the 2nd call, the FacebookConnectPlugin.m sets the graphCallbackId value to 2nd call's callbackId.
So, the 1st call will get the response from the Facebook API first, and then callback to 2nd request.

thx

[moperacz]

any news about this pr?

[aogilvie]

I'll taste a look this week. I'm behind on tracking fb plugin related issues. However, anyone is open to review it!

[mwillbanks]

Have experienced this same issue; merged patch into my own branch and works like a charm. The code change is quite simple and relatively self contained. @aogilvie can you please merge?

[mwillbanks]

This race condition also applies on the iOS side.