Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to create new session per request in RequestsClient #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option to create new session per request in RequestsClient #399

wants to merge 1 commit into from

Conversation

hoou
Copy link

@hoou hoou commented Dec 5, 2018 •
edited
Loading

Description can be found in CHANGELOG-MASTER.rst

@coveralls
Copy link

coveralls commented Dec 8, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 98.509% when pulling a6902cd on hoou:hoou/session-per-request into 0b3e090 on Yelp:master.

macisamuele
macisamuele requested changes Jan 3, 2019
View reviewed changes
Copy link
Collaborator

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test coverage to your changes

bravado/requests_client.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macisamuele macisamuele macisamuele requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoou @coveralls @macisamuele