Handling Added events #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmanElsaban
changed the title
EmanElsaban
force-pushed
the
u/emanelsabban/handling-added-events
branch
from
4e03b9b
to
52b20a5
Compare
nemacysts
reviewed
Jan 19, 2024
| @@ -388,7 +471,7 @@ def _process_pod_event(self, event: PodEvent) -> None: | |||
| elif event["type"] == "DELETED": | |||
| self.__handle_deleted_pod_event(event) | |||
|
|
|||
| elif event["type"] == "MODIFIED": | |||
| elif event["type"] == "MODIFIED" or event["type"] == "ADDED": | |||
There was a problem hiding this comment.
Suggested change
| elif event["type"] == "MODIFIED" or event["type"] == "ADDED": | |
| elif event["type"] in {"MODIFIED", "ADDED"}: |
would be a little more idiomatic/shorter, but the current code works as well :)
EmanElsaban
force-pushed
the
u/emanelsabban/handling-added-events
branch
4 times, most recently
from
1ee611d
to
1c84fd1
Compare
nemacysts
reviewed
Jan 19, 2024
Comment on lines
407
to
410
| # we might see that their are gaps 0.5s because thats how long it will take it to see if there are stuff in the queue | ||
| # will give you whats in the queue or wait 0.5 sec to receive events, if no events are received then it will throw the empty exception | ||
| # and start again | ||
| # I think below might be taking some time to get from a queue an event, should time these two separately |
There was a problem hiding this comment.
we can probably remove this since there's no more timers here :)
| @@ -210,7 +210,7 @@ def __update_modified_pod(self, pod: V1Pod, event: Optional[PodEvent]) -> None: | |||
|
|
|||
| if pod.status.phase not in SUPPORTED_POD_MODIFIED_EVENT_PHASES: | |||
| logger.debug( | |||
| f"Got a MODIFIED event for {pod_name} for unhandled phase: " | |||
| f"Got a {event['type']} event for {pod_name} for unhandled phase: " | |||
There was a problem hiding this comment.
i wonder if we can do something like:
def __update_modified_pod(self, pod: V1Pod, event: Optional[PodEvent]) -> None:
...
event_type = event['type'] if event else "null"
...to handle the null event case (from reconciling)
EmanElsaban
force-pushed
the
u/emanelsabban/handling-added-events
branch
from
1c84fd1
to
0beaaac
Compare
nemacysts
changed the title
nemacysts
approved these changes
Jan 23, 2024
nemacysts
approved these changes
Jan 23, 2024
KaspariK
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR currently contains: