support projected service account volumes #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
approved these changes
Jun 6, 2024
| def _get_service_account_token_volume_name(audience: str) -> str: | ||
| """Generate name for service account projected volume | ||
|
|
||
| :param str audience: audience of the authentication token |
There was a problem hiding this comment.
i'm personally not a fan of repeating the type in the docstring - it's a bit redundant when the function itself is typed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the equivalent of Yelp/paasta#3859 in the land of task-processing.
I'll then proceed to implement the equivalent of Yelp/paasta#3888 within Tron.