Merge pull request #102 from YotpoLtd/Yes_62_Fix_Sniffer_issue_on_the…

…_latest_extention Yes_62_Fix_Sniffer_issue_on_the_latest_extention
YotpoLtd · Aug 19, 2018 · 599aa63 · 599aa63
2 parents 05c4a8e + e82cf29
commit 599aa63
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Helper/ApiClient.php b/Helper/ApiClient.php
@@ -171,7 +171,7 @@ public function createApiGet($path, $timeout = self::DEFAULT_TIMEOUT) {
             $http->write(\Zend_Http_Client::GET, $feed_url, '1.1', array('Content-Type: application/json'));
             $resData = $http->read();
             return array("code" => \Zend_Http_Response::extractCode($resData), "body" => json_decode(\Zend_Http_Response::extractBody($resData)));
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             $this->_logger->addDebug('error: ' . $e);
         }
     }

diff --git a/Helper/RichSnippets.php b/Helper/RichSnippets.php
@@ -19,11 +19,13 @@ public function __construct(
             \Yotpo\Yotpo\Block\Config $config,
             \Yotpo\Yotpo\Model\Richsnippet $model,
             \Yotpo\Yotpo\Helper\ApiClient $helper,
+			\Psr\Log\LoggerInterface $logger,
             \Magento\Store\Model\StoreManagerInterface $storeManager     
             ) {
         $this->_config = $config;
         $this->_model = $model;
         $this->_helper = $helper;
+		$this->_logger = $logger;
         $this->_storeManager = $storeManager;
     }
 
@@ -43,7 +45,7 @@ public function getRichSnippet() {
                 //no snippet for product or snippet isn't valid anymore. get valid snippet code from yotpo api
                 $res = $this->_helper->createApiGet("products/" . ($this->_config->getAppKey()) . "/richsnippet/" . $productId, 2);
 
-                print_r(json_encode($res));
+
                 if ($res["code"] != 200) {
                     //product not found or feature disabled.
                     return "";
@@ -68,8 +70,8 @@ public function getRichSnippet() {
                 return array("average_score" => $averageScore, "reviews_count" => $reviewsCount);
             }
             return array("average_score" => $snippet->getAverageScore(), "reviews_count" => $snippet->getReviewsCount());
-        } catch (Exception $e) {
-            Mage::log($e);
+        } catch (\Exception $e) {
+            $this->_logger->addDebug('error: ' . $e);
         }
         return array();
     return true;

diff --git a/Model/Observer/RemoveBlock.php b/Model/Observer/RemoveBlock.php
@@ -27,8 +27,7 @@ public function execute(Observer $observer) {
             $remove = $this->_scopeConfig->getValue(
                     'yotpo/settings/mdr_enabled', \Magento\Store\Model\ScopeInterface::SCOPE_STORE
             );
-            echo $remove;
-
+
             if ($remove) {
 
                 $layout->unsetElement('reviews.tab');