Include retry support in connectionError #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks.. i thought about a retry too, but then i dont know.. how often does one expect the libvirt daemon is randomly restarted? And how long is it "gone"? I mean, during host OS updates ok, then you should probably time your backups better.. But the daemon in libvirtd suggests its a service which i would expect not to randomly restart and beeing unavailable over large periods of time often? |
|
Yes, I understand, the normal thing is that libvirt is working normally, in case due to user or system error (attack, libvirt bug, etc. and it restarts automatically with some monit-type monitoring system, ) if libvirt stops, at least have a few retries to cancel the job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.