feat(api): improved error objects #1217
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
api/suggested-fees.ts
Outdated
| throw new InputError("Sent amount is too low relative to fees"); | ||
| throw new AmountTooLowError({ | ||
| message: `Sent amount is too low relative to fees. Minimum deposit is ${ethers.utils.formatUnits( | ||
| minDeposit, |
There was a problem hiding this comment.
There is a UX quirk on sharing minDeposit: it's set predominantly based on destination gas, so it's subject to fluctuate slightly between queries. If a caller gets this error response and then resubmits w/ minDeposit there's a decent chance that it will fail again, and they'll need to set another minDeposit.
idk whether we can (or even should) do anything about that in this context, but it's worth thinking about for a follow-up change. The only thing I can think of is it round minDeposit up to some round number to give some padding. That's an approach with its own flaws, though.
There was a problem hiding this comment.
Hmm yea that's a good point. I will remove the value from he error then for now
Closes ACX-2705
This PR proposes improved error objects returned by the API. The goal is to have better DX and debugging possibilities.