Skip to content

Commit

Permalink
Remove maxsize diagnostic
Browse files Browse the repository at this point in the history
Motivation:
1. It tests for issue that only affects *EOLed* Windows 1903/1909
2. It doesn't work properly on Windows Server newer than 1909
because it tries to run incompatible container with process isolation
3. There's already check in `WindowsUtils.isBlacklistedWindowsHost`
that will prevent user from running ue4-docker on affected systems

resolves #263
  • Loading branch information
slonopotamus committed Jun 8, 2022
1 parent d973bd8 commit bdb03ce
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 94 deletions.
1 change: 0 additions & 1 deletion ue4docker/diagnostics/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from .diagnostic_all import allDiagnostics
from .diagnostic_8gig import diagnostic8Gig
from .diagnostic_20gig import diagnostic20Gig
from .diagnostic_maxsize import diagnosticMaxSize
from .diagnostic_network import diagnosticNetwork
2 changes: 0 additions & 2 deletions ue4docker/diagnostics/diagnostic_all.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from .base import DiagnosticBase
from .diagnostic_8gig import diagnostic8Gig
from .diagnostic_20gig import diagnostic20Gig
from .diagnostic_maxsize import diagnosticMaxSize
from .diagnostic_network import diagnosticNetwork


Expand All @@ -28,7 +27,6 @@ def run(self, logger, args=[]):
diagnostics = [
diagnostic8Gig(),
diagnostic20Gig(),
diagnosticMaxSize(),
diagnosticNetwork(),
]
for index, diagnostic in enumerate(diagnostics):
Expand Down
90 changes: 0 additions & 90 deletions ue4docker/diagnostics/diagnostic_maxsize.py

This file was deleted.

1 change: 0 additions & 1 deletion ue4docker/diagnostics_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ def diagnostics():
"all": allDiagnostics(),
"8gig": diagnostic8Gig(),
"20gig": diagnostic20Gig(),
"maxsize": diagnosticMaxSize(),
"network": diagnosticNetwork(),
}

Expand Down

0 comments on commit bdb03ce

Please sign in to comment.