infra-apps: actually update mimir-distributed #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/M
tongpu
force-pushed
the
chore/update_mimir-distributed_follow-up
branch
from
b76830b
to
3605740
Compare
github-actions
bot
added
size/XS
eyenx
reviewed
Jun 28, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I forgot to actually update mimir-distributed in the previous PR #1060. This is the follow-up to bump
Issues
Check if your setup requires [zone aware replication[(https://grafana.com/docs/mimir/latest/configure/configure-zone-aware-replication/) and disable it if not required (
ingester.zoneAwareReplication.enabled=false,store_gateway.zoneAwareReplication.enabled=false).Additionally verify that your Mimir deployment used structuredConfig instead of config, otherwise the upgrade might fail.
Checklist
artifacthub.io/changesannotation inChart.yaml, check the example in the documentation.pre-commit rundocs/