Summary
There is improper sanitization on Service template name which is reflecting in delete button onclick event. This value can be modified and crafted as any other javascript code.
Vulnerable Code
https://github.com/librenms/librenms/blob/a61c11db7e8ef6a437ab55741658be2be7d14d34/app/Http/Controllers/ServiceTemplateController.php#L67C23-L67C23
Above is vulnerable code line which needs to be properly sanitized
PoC
- Go to /services/templates
- Enter name as
testing', '14', 'http://172.105.62.194:8000/services/templates/14');alert(1);//
- Submit it and try to delete it, you will see popup
If you inspect element on delete button, you will notice this:-
Impact
Cross site scripting can lead to cookie stealing or an attacker can execute any other feature using this feature.
References
rook1337 Reporter
Summary
There is improper sanitization on Service template name which is reflecting in delete button onclick event. This value can be modified and crafted as any other javascript code.
Vulnerable Code
https://github.com/librenms/librenms/blob/a61c11db7e8ef6a437ab55741658be2be7d14d34/app/Http/Controllers/ServiceTemplateController.php#L67C23-L67C23
Above is vulnerable code line which needs to be properly sanitized
PoC
testing', '14', 'http://172.105.62.194:8000/services/templates/14');alert(1);//If you inspect element on delete button, you will notice this:-
Impact
Cross site scripting can lead to cookie stealing or an attacker can execute any other feature using this feature.
References