Impact
SQL Injection vulnerability in entities for applications generated with the option "reactive with Spring WebFlux" enabled and an SQL database using r2dbc. Applications created without "reactive with Spring WebFlux" and applications with NoSQL databases are not affected.
If you have generated a microservice Gateway using the affected version, you might be impacted as Gateways are reactive by default.
Currently, SQL injection is possible in the findAllBy(Pageable pageable, Criteria criteria) method of an entity repository class generated in these applications as the where clause using Criteria for queries are not sanitized and user input is passed on as it is by the criteria.
Impacted applications
- Monolith and microservice applications with SQL database and reactive with Spring WebFlux combination (other combinations are not affected and the issue is only present when you generate entities)
- Gateway applications with SQL database (issue will appear only when generating entities)
Patches
Patched in v7.8.1
The findAllBy(Pageable pageable, Criteria criteria) method has been removed from the entity repositories and org.springframework.data.relational.core.query.Criteria support in the underlying methods has been replaced with org.springframework.data.relational.core.sql.Condition. This means you won't be able to do custom filtering in the generated applications.
If you have existing reactive applications generated by the impacted version, we advise you to audit for use of Criteria and take appropriate actions.
Workarounds
The problem lies in the EntityManager.java class when creating the where clause via Conditions.just(criteria.toString()).
just accepts the literal string provided. Criteria's toString method returns a plain string and this combination is vulnerable to sql injection as the string is not sanitized and will contain whatever used passed as input using any plain SQL
So be careful when combining criterias and conditions. As a workaround we have removed the possibility to pass any user-provided criteria to the createSelect method of EntityManager.
Example
Criteria criteria = Criteria.where("name").is("foobar';DROP TABLE example;--"); // parameter is user provided input
criteria.toString(); // --> "'foobar';DROP TABLE example;--'"References
More details in this Issue report
For more information
If you have any questions or comments about this advisory:
References
atomfrede Analyst
pascalgrimaud Analyst
appkr Analyst
OmarHawk Analyst
deepu105 Analyst
Impact
SQL Injection vulnerability in entities for applications generated with the option "reactive with Spring WebFlux" enabled and an SQL database using r2dbc. Applications created without "reactive with Spring WebFlux" and applications with NoSQL databases are not affected.
If you have generated a microservice Gateway using the affected version, you might be impacted as Gateways are reactive by default.
Currently, SQL injection is possible in the
findAllBy(Pageable pageable, Criteria criteria)method of an entity repository class generated in these applications as the where clause using Criteria for queries are not sanitized and user input is passed on as it is by the criteria.Impacted applications
Patches
Patched in v7.8.1
The
findAllBy(Pageable pageable, Criteria criteria)method has been removed from the entity repositories andorg.springframework.data.relational.core.query.Criteriasupport in the underlying methods has been replaced withorg.springframework.data.relational.core.sql.Condition. This means you won't be able to do custom filtering in the generated applications.If you have existing reactive applications generated by the impacted version, we advise you to audit for use of
Criteriaand take appropriate actions.Workarounds
The problem lies in the
EntityManager.javaclass when creating the where clause viaConditions.just(criteria.toString()).justaccepts the literal string provided. Criteria'stoStringmethod returns a plain string and this combination is vulnerable to sql injection as the string is not sanitized and will contain whatever used passed as input using any plain SQLSo be careful when combining criterias and conditions. As a workaround we have removed the possibility to pass any user-provided criteria to the
createSelectmethod ofEntityManager.Example
References
More details in this Issue report
For more information
If you have any questions or comments about this advisory:
References