changes to model

now enforces name for mpsk client refactoring changed name Signed-off-by: Alex <[email protected]> #744
agdsn · Sep 15, 2024 · 2083840 · 2083840
1 parent 9ecb52b
commit 2083840
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pycroft/lib/mpsk_client.py b/pycroft/lib/mpsk_client.py
@@ -9,7 +9,7 @@
 
 
 @with_transaction
-def host_delete(host: MSPKClient, processor: User) -> None:
+def mpsk_delete(host: MSPKClient, processor: User) -> None:
     message = deferred_gettext("Deleted host '{}'.").format(host.name)
     log_user_event(author=processor, user=host.owner, message=message.to_json())
 
@@ -30,8 +30,8 @@ def change_mac(client: MSPKClient, mac: str, processor: User) -> MSPKClient:
     old_mac = client.mac
     client.mac = mac
     message = deferred_gettext("Changed MAC address from {} to {}.").format(old_mac, mac)
-    if client.host.owner:
-        log_user_event(message.to_json(), processor, client.host.owner)
+    if client.owner:
+        log_user_event(message.to_json(), processor, client.owner)
     return client
 
 

diff --git a/pycroft/model/mspk_client.py b/pycroft/model/mspk_client.py
@@ -18,7 +18,7 @@
 
 class MSPKClient(IntegerIdModel):
 
-    name: Mapped[str | None] = mapped_column(String)
+    name: Mapped[str] = mapped_column(String, nullable=False)
 
     owner_id: Mapped[int | None] = mapped_column(
         ForeignKey(User.id, ondelete="CASCADE"), index=True