Skip to content

Commit

Permalink
Make scheduled_membership_* implementations more concise
Browse files Browse the repository at this point in the history
  • Loading branch information
lukasjuhrich committed Sep 20, 2024
1 parent 1852957 commit 712f71b
Showing 1 changed file with 6 additions and 12 deletions.
18 changes: 6 additions & 12 deletions pycroft/lib/user/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,25 +60,19 @@ def scheduled_membership_start(user: User) -> date | None:
:return: The due date of the task that will begin a membership; None if not
existent
"""

begin_task = membership_beginning_task(user)

end_date = None if begin_task is None else begin_task.due.date()

return end_date
if (task := membership_beginning_task(user)) is None:
return None
return task.due.date()


def scheduled_membership_end(user: User) -> date | None:
"""
:return: The due date of the task that will end the membership; None if not
existent
"""

ending_task = membership_ending_task(user)

end_date = None if ending_task is None else ending_task.due.date()

return end_date
if (task := membership_ending_task(user)) is None:
return None
return task.due.date()


def membership_beginning_task(user: User) -> UserTask:
Expand Down

0 comments on commit 712f71b

Please sign in to comment.