Skip to content

Commit

Permalink
FHIR-46548: where clause on alias hapifhir#1748
Browse files Browse the repository at this point in the history
  • Loading branch information
@oliveregger
oliveregger committed Sep 18, 2024
1 parent 0c7e6ce commit d69a8e3
Show file tree
Hide file tree
Showing 2 changed files with 60 additions and 14 deletions.
61 changes: 47 additions & 14 deletions org.hl7.fhir.r5/src/main/java/org/hl7/fhir/r5/utils/structuremap/StructureMapUtilities.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1075,19 +1075,16 @@ private void parseSource(StructureMapGroupRuleComponent rule, FHIRLexer lexer) t
if (lexer.hasToken("where")) {
lexer.take();
ExpressionNode node = fpe.parse(lexer);
source.setUserData(MAP_WHERE_EXPRESSION, node);
source.setCondition(node.toString());
}
if (lexer.hasToken("check")) {
lexer.take();
ExpressionNode node = fpe.parse(lexer);
source.setUserData(MAP_WHERE_CHECK, node);
source.setCheck(node.toString());
}
if (lexer.hasToken("log")) {
lexer.take();
ExpressionNode node = fpe.parse(lexer);
source.setUserData(MAP_WHERE_CHECK, node);
source.setLogMessage(node.toString());
}
}
Expand Down Expand Up @@ -1601,6 +1598,7 @@ private List<Variables> processSource(String ruleId, TransformContext context, V
ExpressionNode expr = (ExpressionNode) src.getUserData(MAP_SEARCH_EXPRESSION);
if (expr == null) {
expr = fpe.parse(src.getElement());
patchVariablesInExpression(expr, vars);
src.setUserData(MAP_SEARCH_EXPRESSION, expr);
}
String search = fpe.evaluateToString(vars, null, null, new StringType(), expr); // string is a holder of nothing to ensure that variables are processed correctly
Expand Down Expand Up @@ -1629,17 +1627,21 @@ private List<Variables> processSource(String ruleId, TransformContext context, V
}
items.removeAll(remove);
}

if (src.hasCondition()) {
ExpressionNode expr = (ExpressionNode) src.getUserData(MAP_WHERE_EXPRESSION);
if (expr == null) {
expr = fpe.parse(src.getCondition());
// fpe.check(context.appInfo, ??, ??, expr)
patchVariablesInExpression(expr, vars);
src.setUserData(MAP_WHERE_EXPRESSION, expr);
}
List<Base> remove = new ArrayList<Base>();
for (Base item : items) {
if (!fpe.evaluateToBoolean(vars, null, null, item, expr)) {
Variables varsForSource = vars.copy();
if (src.hasVariable()) {
varsForSource.add(VariableMode.INPUT, src.getVariable(), item);
}
if (!fpe.evaluateToBoolean(varsForSource, null, null, item, expr)) {
log(indent + " condition [" + src.getCondition() + "] for " + item.toString() + " : false");
remove.add(item);
} else
Expand All @@ -1652,12 +1654,15 @@ private List<Variables> processSource(String ruleId, TransformContext context, V
ExpressionNode expr = (ExpressionNode) src.getUserData(MAP_WHERE_CHECK);
if (expr == null) {
expr = fpe.parse(src.getCheck());
// fpe.check(context.appInfo, ??, ??, expr)
patchVariablesInExpression(expr, vars);
src.setUserData(MAP_WHERE_CHECK, expr);
}
List<Base> remove = new ArrayList<Base>();
for (Base item : items) {
if (!fpe.evaluateToBoolean(vars, null, null, item, expr))
Variables varsForSource = vars.copy();
if (src.hasVariable()) {
varsForSource.add(VariableMode.INPUT, src.getVariable(), item);
}
if (!fpe.evaluateToBoolean(varsForSource, null, null, item, expr))
throw new FHIRException("Rule \"" + ruleId + "\": Check condition failed");
}
}
Expand All @@ -1666,16 +1671,21 @@ private List<Variables> processSource(String ruleId, TransformContext context, V
ExpressionNode expr = (ExpressionNode) src.getUserData(MAP_WHERE_LOG);
if (expr == null) {
expr = fpe.parse(src.getLogMessage());
// fpe.check(context.appInfo, ??, ??, expr)
patchVariablesInExpression(expr, vars);
src.setUserData(MAP_WHERE_LOG, expr);
}
CommaSeparatedStringBuilder b = new CommaSeparatedStringBuilder();
for (Base item : items)
b.appendIfNotNull(fpe.evaluateToString(vars, null, null, item, expr));
for (Base item : items) {
Variables varsForSource = vars.copy();
if (src.hasVariable()) {
varsForSource.add(VariableMode.INPUT, src.getVariable(), item);
}
b.appendIfNotNull(fpe.evaluateToString(varsForSource, null, null, item, expr));
}
if (b.length() > 0)
services.log(b.toString());
}


if (src.hasListMode() && !items.isEmpty()) {
switch (src.getListMode()) {
Expand Down Expand Up @@ -1753,6 +1763,29 @@ private void processTarget(String rulePath, TransformContext context, Variables
if (tgt.hasVariable() && v != null)
vars.add(VariableMode.OUTPUT, tgt.getVariable(), v);
}

public static void patchVariablesInExpression(ExpressionNode node, Variables vars) {
if (node.isProximal() && node.getKind() == ExpressionNode.Kind.Name && node.getName() !=null && node.getName().length()>0 && !node.getName().startsWith("%")) {
// Check if this name is in the variables
if (vars.get(VariableMode.INPUT, node.getName())!=null)
node.setName("%" + node.getName());
}
// walk into children
var next = node.getOpNext();
if (next != null)
patchVariablesInExpression(next, vars);
var grp = node.getGroup();
if (grp != null)
patchVariablesInExpression(grp, vars);
var inner = node.getInner();
if (inner != null)
patchVariablesInExpression(inner, vars);
if (node.parameterCount() > 0) {
for(ExpressionNode p : node.getParameters()) {
patchVariablesInExpression(p, vars);
}
}
}

private Base runTransform(String rulePath, TransformContext context, StructureMap map, StructureMapGroupComponent group, StructureMapGroupRuleTargetComponent tgt, Variables vars, Base dest, String element, String srcVar, boolean root) throws FHIRException {
try {
Expand Down Expand Up @@ -1793,6 +1826,7 @@ else if (srcVar != null) {
ExpressionNode expr = (ExpressionNode) tgt.getUserData(MAP_EXPRESSION);
if (expr == null) {
expr = fpe.parse(getParamStringNoNull(vars, tgt.getParameter().get(tgt.getParameter().size() - 1), tgt.toString()));
patchVariablesInExpression(expr, vars);
tgt.setUserData(MAP_EXPRESSION, expr);
}
List<Base> v = fpe.evaluate(vars, null, null, tgt.getParameter().size() == 2 ? getParam(vars, tgt.getParameter().get(0)) : new BooleanType(false), expr);
Expand Down Expand Up @@ -2520,7 +2554,6 @@ private TypeDetails analyseTransform(TransformContext context, StructureMap map,
ExpressionNode expr = (ExpressionNode) tgt.getUserData(MAP_EXPRESSION);
if (expr == null) {
expr = fpe.parse(getParamString(vars, tgt.getParameter().get(tgt.getParameter().size() - 1)));
tgt.setUserData(MAP_WHERE_EXPRESSION, expr);
}
return fpe.check(vars, null, expr);
case TRANSLATE:
Expand Down
13 changes: 13 additions & 0 deletions org.hl7.fhir.r5/src/test/java/org/hl7/fhir/r5/test/StructureMapUtilitiesTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,19 @@ public void testDateOpVariables() throws IOException, FHIRException {
assertEquals("2023-10-26", fp.evaluateToString(target, "birthDate"));
assertEquals("2023-09-20T13:19:13.502Z", fp.evaluateToString(target, "deceased"));
}

@Test
public void testWhereClause() throws IOException, FHIRException {
StructureMapUtilities scu = new StructureMapUtilities(context, this);
scu.setDebug(true);
String fileMap = TestingUtilities.loadTestResource("r5", "structure-mapping", "whereclause.map");
Element source = Manager.parseSingle(context, TestingUtilities.loadTestResourceStream("r4", "examples", "capabilitystatement-example.json"), FhirFormat.JSON);
StructureMap structureMap = scu.parse(fileMap, "whereclause");
Element target = Manager.build(context, scu.getTargetType(structureMap));
scu.transform(null, source, structureMap, target);
FHIRPathEngine fp = new FHIRPathEngine(context);
assertEquals("true", fp.evaluateToString(target, "rest.resource.interaction.where(code='create').exists()"));
}

private void assertSerializeDeserialize(StructureMap structureMap) {
Assertions.assertEquals("syntax", structureMap.getName());
Expand Down

0 comments on commit d69a8e3

Please sign in to comment.