Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generalized workshop TTM model notebooks and pipeline #536

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Added generalized workshop TTM model notebooks and pipeline #536

merged 1 commit into from
Jul 20, 2022

Conversation

oindrillac
Copy link
Member

@oindrillac oindrillac commented Jul 19, 2022 •
edited
Loading

Related Issues and Dependencies

related #529
related #502

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Modified time to merge training notebooks and pipeline to make it generic and parametrized and suitable for workshop.

Description

  1. Made workflow and comments in notebook more generic - can be applied to any repo and org. Parameterized everything to make it suitable to any repo.
  2. Added notes and comments in notebooks for better understanding
  3. Modified pipeline - succesful run https://ml-pipeline-ui-kubeflow.apps.smaug.na.operate-first.cloud/#/runs/details/c20a30b7-3809-4b59-81a5-edf4030c164f
  4. Added sample .env file

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@sesheta sesheta added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 19, 2022
@oindrillac oindrillac force-pushed the workshop branch 2 times, most recently from 5f96e8a to 6a4309e Compare July 19, 2022 19:41
@oindrillac oindrillac changed the title [WIP] Added generalized workshop TTM model notebooks and pipeline Added generalized workshop TTM model notebooks and pipeline Jul 19, 2022
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2022
@oindrillac
Copy link
Member Author

Added workshop files. @suppathak @aakankshaduggal please take a look :)

aakankshaduggal
aakankshaduggal reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@aakankshaduggal aakankshaduggal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Let's get this merged, and add more details to the markdowns so it's more clear for the attendees even if they approach this material after the workshop.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@sesheta
Copy link
Contributor

sesheta commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aakankshaduggal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@sesheta sesheta merged commit 3e4deeb into aicoe-aiops:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aakankshaduggal aakankshaduggal aakankshaduggal left review comments

@MichaelClifford MichaelClifford Awaiting requested review from MichaelClifford MichaelClifford is a code owner

@durandom durandom Awaiting requested review from durandom durandom is a code owner

@tumido tumido Awaiting requested review from tumido tumido is a code owner

@chauhankaranraj chauhankaranraj Awaiting requested review from chauhankaranraj

@suppathak suppathak Awaiting requested review from suppathak

Assignees

@aakankshaduggal aakankshaduggal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oindrillac @sesheta @aakankshaduggal