Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unused code #295

Merged
merged 2 commits into from
May 10, 2024
Merged

Remove some unused code #295

merged 2 commits into from
May 10, 2024

Conversation

av-martin
Copy link
Contributor

No description provided.

@av-martin av-martin requested a review from stefan-av May 10, 2024 08:59
@av-martin av-martin changed the title remove hard coded key Remove some unused code May 10, 2024
Copy link
Contributor

@stefan-av stefan-av left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment exists for the sake of documentation and transparency.
Martin and I concluded that the key used to encrypt affidavits is fetched from the content of the election_config_item. configData.affidavit.encryptionKey is not used in the js_client.
This looks like some leftover code used for testing, therefore, safe to remove.

@av-martin av-martin merged commit 90afc14 into main May 10, 2024
1 check passed
@av-martin av-martin deleted the remove-hardcoded-key branch May 10, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants