Add source for EpoxyCore library to support open-source SwiftUI view implementation #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready for review @airbnb/lottie-ios-maintainers |
calda
force-pushed
the
cal--epoxy-core
branch
2 times, most recently
from
82e7246
to
11d5021
Compare
calda
commented
Jun 26, 2023
| - uses: ./.github/actions/setup | ||
| - name: Lint Embedded Libraries | ||
| run: bundle exec rake lint:EmbeddedLibraries |
There was a problem hiding this comment.
Added a new CI job that lints the Sources/Private/EmbeddedLibraries directory and verifies that it doesn't have any public symbols. Confirmed that it fails as expected if there's an unexpected public symbol:
calda
commented
Jun 26, 2023
| @@ -0,0 +1,39 @@ | |||
| ## EpoxyCore | |||
There was a problem hiding this comment.
Added some discussion about why we include the source of EpoxyCore, plus instructions on how to update this in the future if necessary
thedrick
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
This LGTM @calda - the point about macOS does seem pretty important, especially given that SwiftUI's main conceit is that it can work across all platforms. I wonder how much work it would be to add support for macOS in the future
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
MoroziOS
pushed a commit
to MoroziOS/tmg-lottie-ios
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the source of EpoxyCore 0.9.0 to this repo.
Airbnb has a Lottie
SwiftUI.Viewimplementation which is built using APIs inEpoxyCore. Making that dependency available in this library would let us open source this existing implementation.Embedding the source of EpoxyCore into this repo feels reasonable and has existing precedent (we already integrate the ZipFoundation library in this way). EpoxyCore is only 3000 LOC, so does not meaningfully increase the size of this repo or the size of compiled binaries.
The only downside of this approach I can think of is that EpoxyCore doesn't currently support macOS. If the Lottie SwiftUI implementation uses EpoxyCore it will only be available on iOS and tvOS. I think this is probably an acceptable tradeoff, given the benefits of using the existing high-quality implementation. Thoughts?