Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default ReducedMotionOption #2116

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

calda
Copy link
Member

@calda calda commented Jul 25, 2023

#2110 accidentally set the default ReducedMotionOption to .reducedMotion. I must have updated this while debugging and forgotten to change it back.

This PR updates the default to the expected .systemReducedMotionToggle value.

@calda calda marked this pull request as ready for review July 25, 2023 19:18
Copy link
Contributor

@thedrick thedrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @calda sorry I didn't catch this in my review last time

@calda calda enabled auto-merge (squash) July 25, 2023 19:21
@calda calda merged commit edf0dd8 into master Jul 25, 2023
12 checks passed
@calda calda deleted the cal--fix-default-reduced-motion-option branch July 25, 2023 19:36
iago849 pushed a commit to atteamapps/lottie-ios that referenced this pull request Feb 8, 2024
MoroziOS pushed a commit to MoroziOS/tmg-lottie-ios that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants