Make client mandatory in DataStory

ajthinking · Sep 8, 2024 · 3ee8be5 · 3ee8be5
1 parent ea2b7d6
commit 3ee8be5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/packages/ui/src/components/DataStory/DataStory.tsx b/packages/ui/src/components/DataStory/DataStory.tsx
@@ -33,12 +33,9 @@ export const DataStoryComponent = (
   const [activityGroups, setActivityGroups] = useState<Activity[]>([]);
 
   const { data: tree, loading: treeLoading, error: getTreeError } = useRequest(async() => {
-    return client
-      ? await client.getTree({ path: LocalStorageKey })
-      : Promise.resolve([]);
+    return await client.getTree({ path: LocalStorageKey });
   }, {
     refreshDeps: [client],
-    manual: !client,
   }, []);
   handleRequestError(getTreeError);
 
@@ -47,12 +44,9 @@ export const DataStoryComponent = (
     loading: nodeDescriptionsLoading,
     error: getNodeDescriptionsError
   } = useRequest(async() => {
-    return client
-      ? await client.getNodeDescriptions({ path: LocalStorageKey })
-      : undefined;
+    return client.getNodeDescriptions({ path: LocalStorageKey })
   }, {
     refreshDeps: [client], // Will re-fetch if client changes
-    manual: !client, // If client is not available initially, do not run automatically
   });
   handleRequestError(getNodeDescriptionsError);
 
@@ -74,7 +68,7 @@ export const DataStoryComponent = (
     }
     updateTree(newTree);
 
-    client?.updateTree({ path: LocalStorageKey, tree: newTree });
+    client.updateTree({ path: LocalStorageKey, tree: newTree });
   }, [diagramKey, tree]);
 
   const handleClickExplorerNode = useCallback((node: NodeApi<Tree>) => {

diff --git a/packages/ui/src/components/DataStory/types.ts b/packages/ui/src/components/DataStory/types.ts
@@ -57,7 +57,7 @@ export interface ClientRunParams {
 export type AcitvityBarType = 'node' | 'diagram' | 'settings' | 'explorer';
 
 export type DataStoryProps = {
-  client?: WorkspaceApiClient,
+  client: WorkspaceApiClient,
   server?: ServerConfig;
   initDiagram?: Diagram | null;
   hideControls?: boolean