Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors with -Config when plugin has no question prompts or indentation #756

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix errors with -Config when plugin has no question prompts or indentation #756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d2cc9f
Update 49 EVC Mismatch.ps1
Hossy Jul 29, 2024
2261799
Update 79 Find VMs in Uncontrolled Snapshot Mode.ps1
Hossy Jul 29, 2024
aee8b2d
Update vCheck.ps1
Hossy Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Plugins/60 VM/49 EVC Mismatch.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Start of Settings
# List of VMs for which the EVC mode does not match the Host/Cluster, do not report on any VMs who are defined here
$ExcludeVMs = "Guest Introspection|ExcludeMe"
# End of Settings

Expand Down
1 change: 1 addition & 0 deletions Plugins/60 VM/79 Find VMs in Uncontrolled Snapshot Mode.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ $PluginVersion = 1.6
$PluginCategory = "vSphere"

# Start of Settings
# Do not report uncontrolled snapshots on VMs that are defined here
$ExcludeDS = "ExcludeMe"
# End of Settings

Expand Down
38 changes: 24 additions & 14 deletions vCheck.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function Get-vCheckSetting

<# Search $file_content for name/value pair with ID_Name and return value #>
Function Get-ID-String ($file_content, $ID_name) {
if ($file_content | Select-String -Pattern "\$+$ID_name\s*=") {
if ($file_content | Select-String -Pattern "\$+${ID_name}\s*=") {
$value = (($file_content | Select-String -pattern "\$+${ID_name}\s*=").toString().split("=")[1]).Trim(' "')
return ($value)
}
Expand Down Expand Up @@ -165,14 +165,16 @@ Function Invoke-Settings {

PROCESS {

$file = $OriginalLine = $EndLine = $null
$file = Get-Content $filename
$OriginalLine = ($file | Select-String -Pattern "# Start of Settings").LineNumber
$EndLine = ($file | Select-String -Pattern "# End of Settings").LineNumber
if ($EndLine) { $EndLineActual = $file[$EndLine - 1] }

if (!(($OriginalLine + 1) -eq $EndLine)) {

$Array = @()
$Line = $OriginalLine
$Line = $OriginalLine + 1
$PluginName = (Get-PluginID $Filename).Title

If ($PluginName.EndsWith(".ps1", 1)) {
Expand All @@ -185,11 +187,18 @@ Function Invoke-Settings {

do {

$Question = $file[$Line]
$Line++
$Split = ($file[$Line]).Split("=")
$Var = $Split[0]
$NoQuestion = $Question = $Split = $VarWS = $Var = $CurSet = $null
if ($file[$Line - 1] -match "^\s*#") {
$Question = $file[$Line - 1]
$Line++
} else {
$NoQuestion = $true
}
$Split = ($file[$Line - 1]).Split("=",2)
$VarWS = if ($Split[0] -match "^\s*") { $matches[0] } else { "" }
$Var = $Split[0].Trim()
$CurSet = $Split[1].Trim()
if ($null -eq $Question) { $Question = $Var }

# Check if the current setting is quoted
$String = $false
Expand All @@ -205,23 +214,24 @@ Function Invoke-Settings {
} # end if

If ($String) {
$Array += $Question
$Array += "$Var= `"$NewSet`""
if (-not $NoQuestion) { $Array += $Question }
$Array += "${VarWS}${Var} = `"$NewSet`""
} Else {
$Array += $Question
$Array += "$Var= $NewSet"
if (-not $NoQuestion) { $Array += $Question }
$Array += "${VarWS}${Var} = $NewSet"
} # end if/else

$Line++


} Until ($Line -ge ($EndLine - 1))
} Until ($Line -ge $EndLine)

$Array += "# End of Settings"
$Array += $EndLineActual

$out = @()
$out = $File[0..($OriginalLine - 1)]
$out += $array
$out += $File[$Endline..($file.count - 1)]
$out += $Array
if ($EndLine -lt $file.count) { $out += $File[$Endline..($file.count - 1)] }

if ($GB) {
$out[$SetupLine] = '$SetupWizard = $False'
Expand Down