Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast exception issues. #6092

Merged
merged 2 commits into from
Aug 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.alibaba.druid.sql.dialect.hive.ast.HiveInsertStatement;
import com.alibaba.druid.sql.dialect.hive.ast.HiveMultiInsertStatement;
import com.alibaba.druid.sql.dialect.hive.stmt.HiveCreateFunctionStatement;
import com.alibaba.druid.sql.dialect.hive.stmt.HiveCreateTableStatement;
import com.alibaba.druid.sql.dialect.hive.stmt.HiveLoadDataStatement;
import com.alibaba.druid.sql.dialect.hive.stmt.HiveMsckRepairStatement;
import com.alibaba.druid.sql.visitor.SQLASTVisitor;
Expand Down Expand Up @@ -73,4 +74,11 @@ default boolean visit(HiveAddJarStatement x) {

default void endVisit(HiveAddJarStatement x) {
}

default boolean visit(HiveCreateTableStatement x) {
return true;
}

default void endVisit(HiveCreateTableStatement x) {
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -518,11 +518,19 @@ protected void printTableOptionsPrefix(SQLCreateTableStatement x) {
}

@Override
public boolean visit(SQLCreateTableStatement x) {
printCreateTable((HiveCreateTableStatement) x, true, true);
public boolean visit(HiveCreateTableStatement x) {
printCreateTable(x, true, true);
return false;
}

@Override
public boolean visit(SQLCreateTableStatement x) {
if (x instanceof HiveCreateTableStatement) {
return visit((HiveCreateTableStatement) x);
}
return super.visit(x);
}

protected void printCreateTable(HiveCreateTableStatement x, boolean printSelect,
boolean printCommentAdvance) {
final SQLObject parent = x.getParent();
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.alibaba.druid.sql.dialect.impala.visitor;

import com.alibaba.druid.sql.dialect.impala.stmt.ImpalaCreateTableStatement;

public interface ImpalaASTVisitor {
default boolean visit(ImpalaCreateTableStatement x) {
return true;
}

default void endVisit(ImpalaCreateTableStatement x) {
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

import java.util.List;

public class ImpalaOutputVisitor extends HiveOutputVisitor {
public class ImpalaOutputVisitor extends HiveOutputVisitor implements ImpalaASTVisitor {
public ImpalaOutputVisitor(StringBuilder appender) {
super(appender);
dbType = DbType.impala;
Expand Down Expand Up @@ -58,11 +58,18 @@ protected void printCached(SQLCreateTableStatement x) {
}

@Override
public boolean visit(SQLCreateTableStatement x) {
printCreateTable((ImpalaCreateTableStatement) x, true, false);
public boolean visit(ImpalaCreateTableStatement x) {
printCreateTable(x, true, false);
return false;
}

@Override
public boolean visit(SQLCreateTableStatement x) {
if (x instanceof ImpalaCreateTableStatement) {
return visit((ImpalaCreateTableStatement) x);
}
return super.visit(x);
}
@Override
protected void printSortedBy(List<SQLSelectOrderByItem> sortedBy) {
if (sortedBy.size() > 0) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ public OdpsOutputVisitor(StringBuilder appender) {
super(appender, DbType.odps);
}

@Override
public boolean visit(SQLCreateTableStatement x) {
if (x instanceof OdpsCreateTableStatement) {
return visit((OdpsCreateTableStatement) x);
}
return super.visit(x);
}

@Override
public boolean visit(OdpsCreateTableStatement x) {
List<SQLCommentHint> headHints = x.getHeadHintsDirect();
if (headHints != null) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import com.alibaba.druid.sql.ast.SQLObject;
import com.alibaba.druid.sql.ast.expr.SQLHexExpr;
import com.alibaba.druid.sql.ast.statement.SQLColumnDefinition;
import com.alibaba.druid.sql.ast.statement.SQLCreateTableStatement;
import com.alibaba.druid.sql.ast.statement.SQLSelect;
import com.alibaba.druid.sql.ast.statement.SQLSelectOrderByItem;
import com.alibaba.druid.sql.ast.statement.SQLTableElement;
Expand Down Expand Up @@ -36,6 +37,15 @@ public SparkOutputVisitor(StringBuilder appender) {
}

//add using statment

@Override
public boolean visit(SQLCreateTableStatement x) {
if (x instanceof SparkCreateTableStatement) {
return visit((SparkCreateTableStatement) x);
}
return super.visit(x);
}

@Override
public boolean visit(SparkCreateTableStatement x) {
print0(ucase ? "CREATE " : "create ");
Expand Down
Loading