Added Check Style #1546
Merged
Added Check Style #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oblodgett
force-pushed
the
add_checkstyle
branch
2 times, most recently
from
90d441f
to
cb9d08b
Compare
oblodgett
requested review from
markquintontulloch,
VarunReddy1111,
adamgibs,
abecerra and
cmpich
oblodgett
force-pushed
the
add_checkstyle
branch
2 times, most recently
from
fb83bc8
to
bf43c97
Compare
devopsagr
reviewed
May 29, 2024
...ration_api/jobs/executors/associations/alleleAssociations/AlleleGeneAssociationExecutor.java
Outdated
Show resolved
Hide resolved
|
@adamgibs this is only for *.java files. I would like to set this up for *.js files but the rules would be different. Maybe we can find an example checkstyle.xml for *.js? |
abecerra
approved these changes
May 29, 2024
|
@oblodgett It looks like checkstyle is specifically for Java. I'm not seeing any examples of using with with JavaScript files. |
cmpich
reviewed
May 29, 2024
|
|
||
| @Inject | ||
| PersonDAO personDAO; | ||
| @Inject PersonDAO personDAO; |
There was a problem hiding this comment.
I like to have the annotation on top of the line it's annotating as it is easier to read for me.
Can we not change this?
cmpich
reviewed
May 29, 2024
| @IndexedEmbedded( | ||
| includePaths = { | ||
| "functionalImpacts.name", "phenotypeTerm.curie", "phenotypeTerm.name", "phenotypeStatement", "evidence.curie", | ||
| "functionalImpacts.name_keyword", "phenotypeTerm.curie_keyword", "phenotypeTerm.name_keyword", "phenotypeStatement_keyword", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add check style which checks the formatting of the code. This will alert to extraneous space in the code or spaces vs tabs, etc. There is 3 major changes (although minor in the grand scheme of things)