-
-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AcceptEntityInput 64bit fix #2149
AcceptEntityInput 64bit fix #2149
Conversation
…to the AcceptEntityInput crash.
Thank you for continuing PR. Looks like this is going to require some fixing on the hl2sdks before the CI can pass. Edit: Editing the AMBuild file of sdktools to suppress the warning-error, could also work. |
It looks like the problem with the CI is because it is not finding variant_t.h from the SDK for some reason.
The include output looks correct except for the fact that game/shared doesn't exist in episode1, it is called game_shared, However game/server/variant_t.h does exist but the compiler says it still can't be found. I'm going to chalk this up to a CI or ambuild problem. |
I think I fixed episode1, but now it is complaining about the SDK. So I believe it's up to @psychonic whether we ignore this error or edit all the SDKs. I think I've done all I can here. Strangely I don't get this error when I compile.
|
4eac489
to
7afe532
Compare
I've now updated the SDK branches that had the bad initialization order. |
c8a344e
to
8b63a09
Compare
Thanks for tackling the rest of this |
Fixes AcceptEntityInput by using the struct definition instead of messy pointer math.
I could not add variant_t.cpp from the sdk because including cbase.h causes a large number of compile errors so I just pasted the 1 method into the sdktools file. If anyone wants to play around with making it work, you can uncomment the file include in the AMBuildScript file in the sdktools folder.
Includes a fix to bintools from malifox which is supposedly related, but I have no idea what it does to be honest.
#2119
I only tested and confirmed this works on Linux and only on int and string variants.