Merge pull request NVIDIA#138 from andmax/fix/am/do_clone_warnings

fix: add final mark in do_clone methods to avoid warnings
alliepiper · Nov 20, 2023 · 7521229 · 7521229
2 parents 978d81a + e7a4ce7
commit 7521229
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/nvbench/float64_axis.cuh b/nvbench/float64_axis.cuh
@@ -40,7 +40,7 @@ struct float64_axis final : public axis_base
   [[nodiscard]] nvbench::float64_t get_value(std::size_t i) const { return m_values[i]; }
 
 private:
-  std::unique_ptr<axis_base> do_clone() const { return std::make_unique<float64_axis>(*this); }
+  std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<float64_axis>(*this); }
   std::size_t do_get_size() const final { return m_values.size(); }
   std::string do_get_input_string(std::size_t i) const final;
   std::string do_get_description(std::size_t i) const final;

diff --git a/nvbench/int64_axis.cuh b/nvbench/int64_axis.cuh
@@ -88,7 +88,7 @@ struct int64_axis final : public axis_base
   };
 
 private:
-  std::unique_ptr<axis_base> do_clone() const { return std::make_unique<int64_axis>(*this); }
+  std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<int64_axis>(*this); }
   std::size_t do_get_size() const final { return m_inputs.size(); }
   std::string do_get_input_string(std::size_t) const final;
   std::string do_get_description(std::size_t) const final;

diff --git a/nvbench/string_axis.cuh b/nvbench/string_axis.cuh
@@ -40,7 +40,7 @@ struct string_axis final : public axis_base
   [[nodiscard]] const std::string &get_value(std::size_t i) const { return m_values[i]; }
 
 private:
-  std::unique_ptr<axis_base> do_clone() const { return std::make_unique<string_axis>(*this); }
+  std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<string_axis>(*this); }
   std::size_t do_get_size() const final { return m_values.size(); }
   std::string do_get_input_string(std::size_t i) const final { return m_values[i]; }
   std::string do_get_description(std::size_t) const final { return {}; }

diff --git a/nvbench/type_axis.cuh b/nvbench/type_axis.cuh
@@ -60,7 +60,7 @@ struct type_axis final : public axis_base
   [[nodiscard]] std::size_t get_type_index(const std::string &input_string) const;
 
 private:
-  std::unique_ptr<axis_base> do_clone() const { return std::make_unique<type_axis>(*this); }
+  std::unique_ptr<axis_base> do_clone() const final { return std::make_unique<type_axis>(*this); }
   std::size_t do_get_size() const final { return m_input_strings.size(); }
   std::string do_get_input_string(std::size_t i) const final { return m_input_strings[i]; }
   std::string do_get_description(std::size_t i) const final { return m_descriptions[i]; }