Encapsulate check for components support in method #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponent` This will allow subclasses to override when components are supported, possibly combining it with when GOV.UK Frontend itself is supported
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5328
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 416cfbc |
JavaScript changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.js b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.js
index 69008e86f..19e286ee0 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend.min.js
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend.min.js
@@ -136,7 +136,10 @@ class GOVUKFrontendComponent {
}(e, t)) throw new InitError(t)
}
checkSupport() {
- if (!isSupported()) throw new SupportError
+ if (!this.isSupported()) throw new SupportError
+ }
+ isSupported() {
+ return isSupported()
}
}
class I18n {
Action run for 416cfbc |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/all.bundle.js b/packages/govuk-frontend/dist/govuk/all.bundle.js
index f4c1a5628..1c67edb22 100644
--- a/packages/govuk-frontend/dist/govuk/all.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/all.bundle.js
@@ -266,10 +266,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/all.bundle.mjs b/packages/govuk-frontend/dist/govuk/all.bundle.mjs
index 8e29d1ad1..f8c1c3ed1 100644
--- a/packages/govuk-frontend/dist/govuk/all.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/all.bundle.mjs
@@ -260,10 +260,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js b/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js
index 1ea530bf9..0b96e7125 100644
--- a/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.js
@@ -200,10 +200,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.mjs
index 941d494c1..4c4530f84 100644
--- a/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/accordion/accordion.bundle.mjs
@@ -194,10 +194,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js b/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js
index 7c75d4d98..07424eb65 100644
--- a/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/button/button.bundle.js
@@ -200,10 +200,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/button/button.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/button/button.bundle.mjs
index fc488920a..d9412f41d 100644
--- a/packages/govuk-frontend/dist/govuk/components/button/button.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/button/button.bundle.mjs
@@ -194,10 +194,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js b/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js
index 92e9f8559..76ce4eea5 100644
--- a/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.js
@@ -231,10 +231,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.mjs
index bf3f2865c..34ee63460 100644
--- a/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/character-count/character-count.bundle.mjs
@@ -225,10 +225,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js b/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js
index 459b25eda..b77f9b743 100644
--- a/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.js
@@ -111,10 +111,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.mjs
index 49bdeba72..e3c1fd925 100644
--- a/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/checkboxes/checkboxes.bundle.mjs
@@ -105,10 +105,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js b/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js
index 11dde3fc3..99c71b5ff 100644
--- a/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.js
@@ -230,10 +230,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.mjs
index 32d877a4b..8600154f1 100644
--- a/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/error-summary/error-summary.bundle.mjs
@@ -224,10 +224,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js b/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js
index db5ac14ff..fb4533397 100644
--- a/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.js
@@ -200,10 +200,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.mjs
index bca3e20dd..714daefad 100644
--- a/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/exit-this-page/exit-this-page.bundle.mjs
@@ -194,10 +194,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js b/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js
index 2977098ff..5bbcbe1be 100644
--- a/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/header/header.bundle.js
@@ -119,10 +119,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/header/header.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/header/header.bundle.mjs
index 81aa86e4b..224c11925 100644
--- a/packages/govuk-frontend/dist/govuk/components/header/header.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/header/header.bundle.mjs
@@ -113,10 +113,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js b/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js
index 9fe1ed201..6a44dd11c 100644
--- a/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.js
@@ -224,10 +224,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.mjs
index 816f0c522..7b0c12d39 100644
--- a/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/notification-banner/notification-banner.bundle.mjs
@@ -218,10 +218,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.js b/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.js
index ad6b0bcae..38adb9a52 100644
--- a/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.js
@@ -205,10 +205,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.mjs
index 75dd1d46e..a0465d235 100644
--- a/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/password-input/password-input.bundle.mjs
@@ -199,10 +199,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js b/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js
index eb9602c40..7444eea07 100644
--- a/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.js
@@ -111,10 +111,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.mjs
index 61a06be92..1fd810d35 100644
--- a/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/radios/radios.bundle.mjs
@@ -105,10 +105,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.js b/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.js
index 18831fdb6..09499031c 100644
--- a/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.js
@@ -119,10 +119,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.mjs
index 99a6ff9f7..c944b0639 100644
--- a/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/service-navigation/service-navigation.bundle.mjs
@@ -113,10 +113,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js b/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js
index 9103ddf5f..29e6e9727 100644
--- a/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.js
@@ -141,10 +141,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.mjs
index 49a20e142..b5b902021 100644
--- a/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/skip-link/skip-link.bundle.mjs
@@ -135,10 +135,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js b/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js
index 64f4c4c80..3400748c8 100644
--- a/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js
+++ b/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.js
@@ -125,10 +125,20 @@
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.mjs b/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.mjs
index d1da839a3..fb5ce2526 100644
--- a/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.mjs
+++ b/packages/govuk-frontend/dist/govuk/components/tabs/tabs.bundle.mjs
@@ -119,10 +119,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
diff --git a/packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs b/packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs
index dac155c9c..2bf203f9d 100644
--- a/packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs
+++ b/packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs
@@ -19,10 +19,20 @@ class GOVUKFrontendComponent {
}
}
checkSupport() {
- if (!isSupported()) {
+ if (!this.isSupported()) {
throw new SupportError();
}
}
+
+ /**
+ * Defines whether the components are supported
+ *
+ * @protected
+ * @returns {boolean} whether the components are supported
+ */
+ isSupported() {
+ return isSupported();
+ }
}
/**
Action run for 416cfbc |
|
Looks good to me! Were we going to add changelog entries going forward or are we going to to do it when we merge this branch into main at the end? |
At the moment, this is only an internal refactoring, as |
Neat, that makes sense! Approved! |
patrickpatrickpatrick
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow subclasses of
GOVUKFrontendComponentto override when components are supported, possibly combining it with when GOV.UK Frontend itself is supported.No CHANGELOG entry as it will only be public with #5327, for which we'll want a unique entry.
Closes #5323