-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate File upload component's value
parameter
#5330
Open
querkmachine
wants to merge
1
commit into
main
Choose a base branch
from
file-upload-deprecate-value-param
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-5330
September 16, 2024 17:40
Inactive
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for cb6d1e2 |
Other changes to npm packagediff --git a/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json b/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json
index 5db62cb10..c7608479a 100644
--- a/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json
+++ b/packages/govuk-frontend/dist/govuk/components/file-upload/macro-options.json
@@ -15,7 +15,7 @@
"name": "value",
"type": "string",
"required": false,
- "description": "Optional initial value of the input."
+ "description": "Deprecated. Optional initial value of the input."
},
{
"name": "disabled",
Action run for cb6d1e2 |
querkmachine
force-pushed
the
file-upload-deprecate-value-param
branch
from
September 16, 2024 17:44
568f013
to
cb6d1e2
Compare
owenatgov
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I'll await a content person to approve it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecates the
value
parameter on the File upload component's Nunjucks macro, as a precursor to removing it with #5311.Although it is likely to be safe to remove the parameter immediately, as it's already non-functional in all modern browsers, we're playing it safe and putting it through the normal deprecation and removal process just in case any implementations or ports expect the parameter to exist.
Changes