Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements so the container can run all its processes without root priveledges #100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

scufre
Copy link

@scufre scufre commented May 26, 2023

These includes the following changes aimed to run the container process without requiring root privileges:

  • Fix the Dockerfile so the default argument is the full path of the run.sh script so the docker-entrypoint.sh script catches it and drops privileges.
  • Changed to use supercronic instead of cron which doesn't require root.
  • Updated so the mysql daemon now runs under the www-data account
  • Added some setup to the docker-entrypoint.sh script to adjust file permissions
  • Changed daemons to log into the /var/log/ampache directory so it can be used as a volume

@lachlan-00
Copy link
Member

that's cool, i've never heard of supercronic before. i work during the week sol i'll check it out then and merge

@KaeTuuN
Copy link

KaeTuuN commented Oct 12, 2023

@scufre Does this still work? Would be great to see it merched!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants