Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added https support #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added https support #36

wants to merge 1 commit into from

Conversation

eilmrein
Copy link

The default image should already support https.

Added port based virtual hosting + self-signed certficates + two new volumes /etc/ssl and /etc/apache2

@lachlan-00
Copy link
Member

@kuzi-moto

@PaulWalkerUK
Copy link

I think it might be better if the certificate was generated by the container instead of being hard-coded in the repo. Doing it this way, everyone has the same private key and it isn’t very private. If the certificate is generated as part of spinning up the container then it will keep them unique

@kuzi-moto
Copy link
Member

I agree, this should be pretty easy to set up on container start.

That being said... I seriously think everyone should use something like Traefik which makes generating certs with Letsencrypt super simple. Alternatively making it easier for people to just generate and use their own certs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants