Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explicit casts #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fix explicit casts #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c23e20e
fix explicit casting
kim-anchorzero Sep 5, 2024
ded111c
add built artifact
kim-anchorzero Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/db/core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ class SQLFragment {
}
else if (typeof expression.cast === 'string') {
result.values.push(expression.value);
result.text += `CAST(${placeholder} AS "${expression.cast}")`;
result.text += `CAST(${placeholder} AS ${expression.cast})`;
}
else {
result.values.push(expression.value);
Expand Down
2 changes: 1 addition & 1 deletion src/db/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ export class SQLFragment<RunResult = pg.QueryResult['rows'], Constraint = never>

} else if (typeof expression.cast === 'string') {
result.values.push(expression.value);
result.text += `CAST(${placeholder} AS "${expression.cast}")`;
result.text += `CAST(${placeholder} AS ${expression.cast})`;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I follow what removing the quotes fixes. Can you elucidate? Quickly checking in pgAdmin query tool seems like the quotes are indeed not needed, but also not harmful there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the quotes I was getting errors.. except when the value was "json." All other quoted type strings would fail.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't argue with empiricism!


} else {
result.values.push(expression.value);
Expand Down