replay: populate block_id and send as part of TowerSync tx #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinSekar
commented
Aug 28, 2024
| /// The unique identifier for the corresponding block for this bank. | ||
| /// None for banks that have not yet completed replay or for leader banks as we cannot populate block_id | ||
| /// until bankless leader. Can be computed directly from shreds without needing to execute transactions. | ||
| block_id: RwLock<Option<Hash>>, |
There was a problem hiding this comment.
Haven't yet added this to the serialized format. This will be done as part of bankless leader in order to add block_id to bank_hash (see AshwinSekar@d351d15)
AshwinSekar
force-pushed
the
block_id
branch
3 times, most recently
from
18ae2e9
to
5679a04
Compare
AshwinSekar
force-pushed
the
block_id
branch
from
5679a04
to
a743e7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The block_id returned after completing the final fec set checks is unused.
Summary of Changes
Add the block_id to the bank (not yet serialized / deserialized) in order to be populated on the TowerSync vote.
Note that this block_id will be None in the case that the bank is our leader bank. This is because we cannot guarantee the shred will be ready.
We can adjust this approach to hold the vote until the last shred is finished, or to simply resend the vote once the last shred is finished (this would involve messing with the timestamp or deduplication code).