Initial declaration of OAuth and OIDC plugin and validator with unimp… #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonofre
requested changes
Jul 28, 2024
| @@ -0,0 +1,19 @@ | |||
| # OAuth and OIDC Implementation for ActiveMQ | |||
There was a problem hiding this comment.
I don't think it makes sense to add a specific README here. Better to add in the doc section.
Also the ASF header is missing.
| @@ -0,0 +1,9 @@ | |||
| # OAuth and OIDC Implementation for ActiveMQ | |||
There was a problem hiding this comment.
bak file should not be part of the PR. Please remove this one.
| <dependency> | ||
| <groupId>com.nimbusds</groupId> | ||
| <artifactId>oauth2-oidc-sdk</artifactId> | ||
| <version>9.15</version> |
There was a problem hiding this comment.
- The version should be managed by dependencyManagement in the root pom.
- These dependencies can be optional I guess.
| @@ -0,0 +1,23 @@ | |||
| package org.apache.activemq.security; | |||
| @@ -0,0 +1,68 @@ | |||
| package org.apache.activemq.security; | |||
| @@ -0,0 +1,18 @@ | |||
| package org.apache.activemq.security; | |||
| @@ -34,6 +34,9 @@ | |||
| <transportConnectors> | |||
| <transportConnector name="openwire" uri="tcp://localhost:61616" /> | |||
| <transportConnector name="stomp" uri="stomp://localhost:61613" /> | |||
| <!-- Add Jetty Transport Connector for Web Console --> | |||
There was a problem hiding this comment.
That's not correct: the jetty transport is not for the webconsole. Jetty transport is for http transport connect.
The WebConsole is managed outside of the broker by inclusion of jetty.xml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial declaration of the dependencies, java classes and the corresponding methods to implement the following jira - https://issues.apache.org/jira/browse/AMQ-9400
Methods are not implemented yet.