[CELEBORN-1277] Add celeborn.quota.enabled at Master and Client side to enable checking quota #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck enable/disable.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2318 +/- ##
==========================================
- Coverage 48.71% 48.63% -0.08%
==========================================
Files 207 207
Lines 12939 12939
Branches 1111 1111
==========================================
- Hits 6302 6291 -11
- Misses 6231 6241 +10
- Partials 406 407 +1 ☔ View full report in Codecov by Sentry. |
RexXiong
reviewed
Feb 23, 2024
|
ping @RexXiong PTAL |
SteNicholas
reviewed
Feb 23, 2024
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
SteNicholas
changed the title
…scala Co-authored-by: Nicholas Jiang <[email protected]>
…scala Co-authored-by: Nicholas Jiang <[email protected]>
…scala Co-authored-by: Nicholas Jiang <[email protected]>
RexXiong
approved these changes
Feb 24, 2024
| val (isAvailable, reason) = | ||
| quotaManager.checkQuotaSpaceAvailable(userIdentifier, userResourceConsumption) | ||
| context.reply(CheckQuotaResponse(isAvailable, reason)) | ||
| if (conf.quotaEnabled) { |
There was a problem hiding this comment.
IMO quotaEnabled should only control quotaManager check quota or not，Resource-related metrics should be independent.
|
Merge to main(v0.5.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add
celeborn.quota.enabledat Master and Client side to enable checking quotaWhy are the changes needed?
celeborn.quota.enabledshould be added in Master and Client side to enable quota check for Celeborn Master and Client.Does this PR introduce any user-facing change?
Add categories of
celeborn.quota,enabledwithmasterandclient.How was this patch tested?
No.