[CELEBORN-1601] Support revise lost shuffles #2746
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxzl25
changed the title
|
@FMX, could you also support the corresponding cli command for the HTTP endpoint to revise lost shuffles? |
Sounds good. I'll add the cli command. |
|
@SteNicholas Thanks. I have added the CLI command and the API endpoint. Please review this PR when you have time. |
SteNicholas
reviewed
Sep 23, 2024
| if (masterOptions.addClusterAlias != null && masterOptions.addClusterAlias.nonEmpty) | ||
| runAddClusterAlias | ||
| if (masterOptions.removeClusterAlias != null && masterOptions.removeClusterAlias.nonEmpty) | ||
| if (masterOptions.removeClusterAlias != null && masterOptions.removeClusterAlias.nonEmpty) { |
SteNicholas
reviewed
Sep 23, 2024
| @@ -107,6 +107,9 @@ enum MessageType { | |||
| REPORT_BARRIER_STAGE_ATTEMPT_FAILURE_RESPONSE = 84; | |||
| SEGMENT_START = 85; | |||
| NOTIFY_REQUIRED_SEGMENT = 86; | |||
|
|
|||
| REVISE_LOST_SHUFFLES = 202; | |||
There was a problem hiding this comment.
Why does the number start from 202?
There was a problem hiding this comment.
To keep compatible with our internal version.
SteNicholas
reviewed
Sep 23, 2024
| @@ -433,6 +436,7 @@ message PbHeartbeatFromApplicationResponse { | |||
| repeated PbWorkerInfo excludedWorkers = 2; | |||
| repeated PbWorkerInfo unknownWorkers = 3; | |||
| repeated PbWorkerInfo shuttingWorkers = 4; | |||
| repeated int32 registeredShuffles = 6; | |||
There was a problem hiding this comment.
Suggested change
| repeated int32 registeredShuffles = 6; | |
| repeated int32 registeredShuffles = 5; |
SteNicholas
reviewed
Sep 23, 2024
| @@ -73,6 +75,7 @@ message ResourceRequest { | |||
| optional WorkerEventRequest workerEventRequest = 22; | |||
| optional ApplicationMetaRequest applicationMetaRequest = 23; | |||
| optional ReportWorkerDecommissionRequest reportWorkerDecommissionRequest = 24; | |||
| optional ReviseLostShufflesRequest reviseLostShufflesRequest = 102; | |||
SteNicholas
reviewed
Sep 23, 2024
| @@ -1069,13 +1096,18 @@ private[celeborn] class Master( | |||
| if (shouldResponse) { | |||
| // UserResourceConsumption and DiskInfo are eliminated from WorkerInfo | |||
| // during serialization of HeartbeatFromApplicationResponse | |||
| var appRelatedShuffles = statusSystem.registeredAppAndShuffles.get(appId) | |||
There was a problem hiding this comment.
Suggested change
| var appRelatedShuffles = statusSystem.registeredAppAndShuffles.get(appId) | |
| val appRelatedShuffles = statusSystem.registeredAppAndShuffles.getOrDefault(appId, Collecitons.emptySet()) |
FMX
force-pushed
the
b1600
branch
2 times, most recently
from
e71ac9e
to
1daa172
Compare
turboFei
reviewed
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To support revising lost shuffle IDs in a long-running job such as flink batch jobs.
Why are the changes needed?
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
Cluster tests.