[CELEBORN-1608] Reduce redundant response for RESTful api #2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
changed the title
turboFei
force-pushed
the
reduce_toomany_resp
branch
from
91446a6
to
48e86ee
Compare
SteNicholas
approved these changes
Sep 23, 2024
FMX
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, for exclude worker api, it will append all the workers info into the response message.
Assume that, we have thousands of workers, the response info is too large and redundant, as we already provide get workers api to return it.
Why are the changes needed?
As title.
Does this PR introduce any user-facing change?
Yes, reduce the response. It should be fine, we already provide the api to get workers details.
How was this patch tested?
Existing UT.