Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge next branch into master #18786

Merged
merged 31 commits into from
Jan 18, 2024
Merged

chore: merge next branch into master #18786

merged 31 commits into from
Jan 18, 2024

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Current next branch contains a PR #17611 that should be included in v5.5.0.

tyn1998 and others added 30 commits August 6, 2022 00:27
@tyn1998
test(universalTransition): a possible test file
6f500be
@tyn1998
wip: successfully get childGroupId (a possible new interface)
0f85029
@tyn1998
wip: can decide "parent2child" or "child2parent"
4d4634f
@tyn1998
wip: new createKeyGetters that suppot multi-drill (but only get key f…
a4cf7f9 
…rom dim)
@tyn1998
wip: should consider getting direction from more ways & using groupId…
788daec 
… only when direction is 'nodirection'
@tyn1998
refactor: rename "KeyDim" to "GroupIdDim"
5063c51
@tyn1998
learning: add some comments
01ba523
@tyn1998
fix: incorrect dataGroupId for old data items in universalTransition
5e475a2
@tyn1998
feat: multiple level drill down (alpha)
6e555b7
@tyn1998
refactor: more readable universalTransition-multiLevelDrillDown.html
9fcbc7c
@tyn1998
docs: add comments for code
ce89ee7
@tyn1998
docs: improve comments in test html
b123f35
@tyn1998
docs: update universalTransition-multiLevelDrilldown.html
6168f98
@Ovilia
Merge pull request #17716 from apache/master
0c82ead 
chore: merge 'master' branch into 'next'
@tyn1998
Merge branch 'master' into feat/multi-drill
e5b9be3
@tyn1998
revert changes introduced by a merge in mistake
d689521
@tyn1998
rename childGroupId to itemChildGroupId to make it consistent wit…
938e415 
…h `itemGroupId`
@tyn1998
no need to return undefined, just return
8e80c01
@tyn1998
use != null to test if equal to undefined or null
55ba825
@tyn1998
not use enum, just use const variables
ffbc6af
@tyn1998
merge getGroupId and getChildGroupId into one function
5321c2d
@tyn1998
use createHashMap() to improve performance
dc9a3f6
@tyn1998
add another test case
6f7a395
@tyn1998
slow down animation update in test cases
edd2d3c
@tyn1998
fix unexpected appearance of xAxis.name after switching options
9d52862
@pissang
Merge pull request #17796 from apache/master
7a12c0b 
Merge branch 'master' into 'next'
@tyn1998
simplify code
3d5b32c
@pissang
Merge pull request #17611 from tyn1998/feat/multi-drill
1dadcab 
feat: multiple level drill down support for universalTransition
@plainheart
Merge pull request #18049 from apache/master
7749341 
Merge branch 'master' into 'next'
@pissang
Merge pull request #18420 from apache/master
5c1c53d 
chore: merge master to next
@Ovilia
Merge pull request #18558 from apache/master
11b4c8e 
chore: merge `master` branch to `next` branch to fix broken nightly-next build
@echarts-bot
Copy link

echarts-bot bot commented Jun 20, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: PR: doc ready, PR: awaiting doc, PR: doc unchanged

This message is shown because the PR description doesn't contain the document related template.

@Ovilia
Copy link
Contributor

Ovilia commented Jun 25, 2023

The next version may not be 5.5.0. If there aren't enough major features, we may still release 5.4.3. So perhaps we should wait until we decide if we should release 5.5.0 as the next version?

@plainheart
Copy link
Member Author

@Ovilia Looked through the merged pull requests, the most are to fix bugs. I have no objection to releasing v5.4.3 instead of v5.5.0.

@plainheart plainheart added this to the 5.5.0 milestone Jun 25, 2023
@plainheart
Copy link
Member Author

plainheart commented Jun 25, 2023 •
edited
Loading

Let's create a milestone for v5.4.3 and move the pull requests and issues to it.

@Ovilia
Copy link
Contributor

Ovilia commented Jun 25, 2023

@plainheart Do you think it could be 5.5.0 if I can complete the SSR client runtime before the next release? I'm working on the building scripts and should be ready in a few days.

@plainheart
Copy link
Member Author

@Ovilia I think the SSR client runtime module could be released together with other three great features like #17471, #17461 and #17611 in v5.5.0. But before that, we can also release a minor version v5.4.3 for bug fixes.

@Ovilia
Copy link
Contributor

Ovilia commented Jun 25, 2023

@plainheart Sure. Let's start the release of 5.4.3 soon. Should this PR be closed for now or turn it into draft?

@plainheart
Copy link
Member Author

@Ovilia I've listed it in v5.5.0. Just leave it alone until v5.5.0 is ready to release.

@plainheart plainheart marked this pull request as draft June 25, 2023 08:22
@plainheart plainheart marked this pull request as ready for review November 30, 2023 07:34
@Ovilia Ovilia merged commit 2438562 into master Jan 18, 2024
2 checks passed
@echarts-bot ECharts Bot
Copy link

echarts-bot bot commented Jan 18, 2024

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@tyn1998
Copy link
Contributor

tyn1998 commented Jan 18, 2024

Thank you all for reviewing and testing the PR and really excited to see the minor work being merged into master! I hope I can contribute more to this wonderful project in future ❤️

@plainheart plainheart removed this from the 5.5.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Ovilia approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plainheart @Ovilia @tyn1998 @pissang