[FLINK-36174][hotfix] CDC yaml without pipeline should not throw exception. #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardBang
reviewed
Aug 29, 2024
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java
Show resolved
Hide resolved
|
@yuxiqian , CC |
yuxiqian
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Should private final PipelineDef minimizedDef field be updated to reflect this change?
There was a problem hiding this comment.
Test YamlPipelineDefinitionParserTest.YamlPipelineDefinitionParserTest will do it.
yuxiqian
reviewed
Aug 31, 2024
Comment on lines
+430
to
+432
| Configuration.fromMap( | ||
| Collections.singletonMap( | ||
| "local-time-zone", ZoneId.systemDefault().toString()))); |
There was a problem hiding this comment.
Seems it's not necessary to pass local-time-zone explicitly since it will be added when constructing PipelineDef anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CDC yaml without pipeline should not throw exception.