Payara 7 and Jakarta EE 11 support #7716
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Java EE/Jakarta EE
|
going to restart CI with enterprise jobs enabled. |
| @@ -30,7 +30,7 @@ | |||
| <goal>compiler:compile</goal> | |||
| <goal>war:exploded</goal> | |||
| <goal>payara-micro:stop</goal> | |||
| <goal>payara-micro:start</goal> | |||
| <goal>payara-micro:dev</goal> | |||
There was a problem hiding this comment.
Will this cause problems for existing installations? The dev-Mojo is only 9 months old, so old projects might hold plugin versions, not supporting this.
| @@ -387,7 +392,7 @@ public boolean equals(final PayaraPlatformVersionAPI version) { | |||
| return this.major == version.getMajor() | |||
| && this.minor == version.getMinor() | |||
| && this.update == version.getUpdate() | |||
| && this.build == version.getBuild(); | |||
| && (this.build == null ? version.getBuild() == null : this.build.equals(version.getBuild())); | |||
There was a problem hiding this comment.
Suggested change
| && (this.build == null ? version.getBuild() == null : this.build.equals(version.getBuild())); | |
| && Objects.equals(this.build, version.getBuild())); |
| assertTrue(major == version.getMajor() | ||
| && minor == version.getMinor() | ||
| && update == version.getUpdate() | ||
| && build == version.getBuild()); | ||
| && (build == null ? version.getBuild() == null : build.equals(version.getBuild()))); |
There was a problem hiding this comment.
Suggested change
| && (build == null ? version.getBuild() == null : build.equals(version.getBuild()))); | |
| && Objects.equals(build, version.getBuild())); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes to support Payara 7 and Jakarta EE 11 in Apache NetBeans:
Updated Build Type Handling:
Changed the method signature from
short getBuild()toString getBuild(). This change allows the system to recognize and list the latestAlphaversions of Payara 7: https://mvnrepository.com/artifact/fish.payara.distributions/payara/7.2024.1.Alpha1Alpha/Beta Version Filtering:
Only the latest
AlphaorBetaversion will now be listed in the available versions. OtherAlphaorBetaversions will be skipped to maintain a cleaner and more relevant version list.Archetype Update for Payara Micro:
The archetype
fish.payara.starter:payara-starter-archetypewill now be used for the Payara Micro 6+.