Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP Client: Reduce concurrency in LSP communication and register document sychronously on startup #7759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

LSP Client: Reduce concurrency in LSP communication and register document sychronously on startup #7759

wants to merge 1 commit into from
+49 −56

Conversation

matthiasblaesing
Copy link
Contributor

  • Run open document registration in LSP servers synchronously with initialization
  • Instead of spinning custom RequestProcessors use the existing queue on the LSP Bindings via runOnBackground
  • Where possible drop RequestProcessor usage and run code directly

Closes: #3812

@matthiasblaesing
LSP Client: Reduce concurrency in LSP communication and register docu…
17bae5a 
…ment sychronously on startup

- Run open document registration in LSP servers synchronously with
  initialization
- Instead of spinning custom RequestProcessors use the existing queue
  on the LSP Bindings via runOnBackground
- Where possible drop RequestProcessor usage and run code directly

Closes: apache#3812
@matthiasblaesing matthiasblaesing added LSP [ci] enable Language Server Protocol tests C/C++ ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 16, 2024
@matthiasblaesing matthiasblaesing added this to the NB24 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vieiro vieiro Awaiting requested review from vieiro

@lahodaj lahodaj Awaiting requested review from lahodaj

Assignees
No one assigned
Labels
C/C++ ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) LSP [ci] enable Language Server Protocol tests
Projects
None yet
Milestone
NB24
Development

Successfully merging this pull request may close these issues.

ide/lsp.client add opened documents after start
1 participant
@matthiasblaesing