Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR number to dev build artifact #7765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbien
Copy link
Member

@mbien mbien commented Sep 18, 2024

@ebarboni had the idea for that - makes it easier to distinguish the artifacts once downloaded

will use github.run_id when run without PR context

going to update the downloader script too assuming this works

@mbien mbien added CI continuous integration changes ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 18, 2024
@mbien mbien added this to the NB24 milestone Sep 18, 2024
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

If I remember correctly we currently don't have actions that run independently of PRs, but what happens when github.event.pull_request is not set then? Will it blow or just result in the name dev-build_?

@mbien
Copy link
Member Author

mbien commented Sep 20, 2024

If I remember correctly we currently don't have actions that run independently of PRs, but what happens when github.event.pull_request is not set then? Will it blow or just result in the name dev-build_?

right. The dev-build step is currently only label-activated, this would mean that the code path would only run with PR context.

I could try something like this though to cover the "what if" scenario:
dev-build_${{github.event.pull_request.number || github.run_id}}

will use github.run_id when run without PR context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) CI continuous integration changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants