Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play Files From Attachments #244

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Play Files From Attachments #244

wants to merge 9 commits into from
+340 −62

Conversation

cycle-five
Copy link

@cycle-five cycle-five commented Jul 17, 2023 •
edited
Loading

- -
Issue #246
Dependencies ffprobe = "0.3.3", reqwest = "0.11.6"
Decisions

@joao-conde
Copy link
Collaborator

@cycle-five can you open an issue that this PR relates too? In that issue you could explain the rationale behind this feature.

StaticRocket
StaticRocket approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@StaticRocket StaticRocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature works and the fragmentation of URL parsing and playback seems rational. Consider this approval superficial though, as I'm no rust expert and can't attest to the implementation.

afonsojramos
afonsojramos requested changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@afonsojramos afonsojramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a half review, need to pay some proper attention to play.rs and file.rs still.

src/handlers/serenity.rs Show resolved Hide resolved
src/handlers/serenity.rs Show resolved Hide resolved
src/handlers/serenity.rs Outdated Show resolved Hide resolved
src/commands/play.rs
@@ -35,58 +43,29 @@ pub enum Mode {
Jump,
}

#[derive(Clone)]
#[derive(Clone, Debug)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we will change this once it is "ready"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually usually leave the Debug derive in because it provides a certain level of detail in logs, but I'll remove it if it's not idiomatic to have in production code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos afonsojramos requested changes

@StaticRocket StaticRocket StaticRocket approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@cycle-five cycle-five

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cycle-five @joao-conde @afonsojramos @StaticRocket