Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10644 related resources filter #10766

Draft
wants to merge 7 commits into
base: dev/7.6.x
Choose a base branch
from

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented Apr 13, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

This PR enables a user to request an additional set of search results comprised of those instances of a chosen Resource Model that are related to any of the results from the search query.

Screenshot 2024-04-12 at 6 12 24 PM Screenshot 2024-04-12 at 6 12 16 PM
  • Needs a migration to insert new Search filter into search_component table
  • This PR was informally based off a customized Search where all hits are returned rather than a page's worth. The all-vs-page_ct approaches should be better accounted for so that the search filter created in this PR knows how to get all the ids from the previous query and also what fraction of the related_results to return

Issues Solved

#10644

Checklist

  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Ticket Background

Further comments

@whatisgalen whatisgalen marked this pull request as draft April 13, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant