Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use immediate card component for lookup instead of parenttile card, r… #11432

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

whatisgalen
Copy link
Member

@whatisgalen whatisgalen commented Sep 5, 2024

…e #11431

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

Closes #11431

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@chiatt chiatt self-requested a review September 10, 2024 22:59
@chiatt chiatt self-assigned this Sep 10, 2024
@jacobtylerwalls
Copy link
Member

Can you add a changelog?

@whatisgalen
Copy link
Member Author

Can you add a changelog?

Just pushed one! Thanks for reviewing!

Copy link
Member

@chiatt chiatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chiatt chiatt merged commit baf531b into dev/7.6.x Sep 20, 2024
7 checks passed
@chiatt chiatt deleted the 11431_child_card_override branch September 20, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Reports) child card components are overridden by parent card component
3 participants