Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial fix for default deny for mvt tiles #11455

Merged
merged 10 commits into from
Sep 20, 2024
Merged

Conversation

aarongundel
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

Issues Solved

Closes #

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • I added a changelog in arches/releases
  • I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Accessibility Checklist

Developer Guide

Topic Changed Retested
Color contrast
Form fields
Headings
Links
Keyboard
Responsive Design
HTML validation
Screen reader

Ticket Background

  • Sponsored by:
  • Found by: @
  • Tested by: @
  • Designed by: @

Further comments

@aarongundel aarongundel marked this pull request as ready for review September 18, 2024 15:41
@chiatt chiatt self-assigned this Sep 18, 2024
@@ -632,6 +580,17 @@ def get_default_permissions(
]
return default_permissions

def get_all_default_permissions(self, model: Model = None):
default_permissions_settings = settings.PERMISSION_DEFAULTS
if not default_permissions_settings or model is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to check for cases in which the graphid is not included in the default_permissions_settings.

if not default_permissions_settings or model is None or model.graph_id not in default_permissions_settings

@chiatt chiatt merged commit 6df07fb into dev/7.6.x Sep 20, 2024
7 checks passed
@chiatt chiatt deleted the adg/11336-deny-mvt branch September 20, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure restricted resources are not represented in vector tiles or the geojson api endpoint
2 participants