-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial fix for default deny for mvt tiles #11455
Merged
Merged
+646
−265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* performance improvements for indexing with default deny * remove commented lines
chiatt
requested changes
Sep 20, 2024
@@ -632,6 +580,17 @@ def get_default_permissions( | |||
] | |||
return default_permissions | |||
|
|||
def get_all_default_permissions(self, model: Model = None): | |||
default_permissions_settings = settings.PERMISSION_DEFAULTS | |||
if not default_permissions_settings or model is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to check for cases in which the graphid is not included in the default_permissions_settings.
if not default_permissions_settings or model is None or model.graph_id not in default_permissions_settings
chiatt
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
Issues Solved
Closes #
Checklist
Accessibility Checklist
Developer Guide
Ticket Background
Further comments