Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface nonexistent model error in JSON-LD importer #11454 #11474

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

jacobtylerwalls
Copy link
Member

@jacobtylerwalls jacobtylerwalls commented Sep 19, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of Change

When uploading a JSON-LD zip referencing a graph that does not exist, the error was no longer surfaced to the user. Now this is fixed.

Issues Solved

Closes #11454

Checklist

  • I targeted one of these branches:
    • dev/7.6.x (under development): features, bugfixes not covered below
    • dev/7.5.x (main support): regressions, crashing bugs, security issues, major bugs in new features
    • dev/6.2.x (extended support): major security issues, data loss issues
  • [n/a -- unreleased] I added a changelog in arches/releases
  • [n/a] I submitted a PR to arches-docs (if appropriate)
  • Unit tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • My test fails on the target branch

Ticket Background

  • Sponsored by: Farallon

@jacobtylerwalls

This comment was marked as resolved.

@jacobtylerwalls jacobtylerwalls force-pushed the jtw/surface-nonexistent-graph-error branch from 5c75a4d to b489ef5 Compare September 20, 2024 02:21
Copy link
Member

@apeters apeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the issue

@apeters apeters merged commit 794558f into dev/7.6.x Sep 20, 2024
7 checks passed
@apeters apeters deleted the jtw/surface-nonexistent-graph-error branch September 20, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-LD bulk importer no longer surfaces error if graph doesn't exist
2 participants