-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not process batches if skip file detected in restore_helper #103
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
ok |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Before that commit there were different lists of oids and batches, so loop in the loop looked natural. Now there is combined oidWithBatchList and IMHO one loop is looking much more relevant. |
This comment was marked as resolved.
This comment was marked as resolved.
Removing oidWithBatchList would bring significant changes into the code and unrelated to the current issue tests. The code will not be smaller or more clean since replicated tables should be processed as well. |
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Georgy Shelkovy <[email protected]>
Co-authored-by: Georgy Shelkovy <[email protected]>
Do not process batches if skip file detected in restore_helper.
When performing restore with resize, batches are used for each table. If the
error happens during restore, there is no need to continue with remaining
batches for this particular table. To signal about an error to the helpers,
main process created skip files.
This patch adds skip of the remaining batches in restore helper when skip file
is detected.