Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADBDEV-4512: Add plugin that writes all the data to /dev/null #44

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

KnightMurloc
Copy link

@KnightMurloc KnightMurloc commented Oct 17, 2023

The plugin just writes all the data to /dev/null. This plugin is supposed to be
used instead of ddboost plugin to check whether gpdb and gpbackup pipeline are
the bottleneck of backup procedure on the given cluster.

The plugin just writes all the data to /dev/null. It can be useful for pipeline
performance testing.
Copy link

@dnskvlnk dnskvlnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make formatting consistent over all functions

@dnskvlnk
Copy link

Please, specify in description that this script is intended to be used instead of actual ddboost plugin, change title to something like "Add plugin that writes to /dev/null" to make it more clear, make formatting more consistent and try to run gpbackup with this plugin

@KnightMurloc KnightMurloc changed the title ADBDEV-4512: Add null plugin for testing ADBDEV-4512: Add plugin that writes all the data to /dev/null Oct 18, 2023
@KnightMurloc
Copy link
Author

and try to run gpbackup with this plugin

I don't have any problems run gpbackup with this plugin. do you have any?

@dnskvlnk
Copy link

No, just checked, everything's fine. Approve

@andr-sokolov andr-sokolov merged commit b00be3c into master Oct 18, 2023
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants